Small cleanup #57
Merged
Small cleanup #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue 55. Functions that don't return a value have caused unpredicatable behavior on Cortex-M3 in the past. Added comment to docs on ARM showing primask register.
Apollo3 doesn't use dedicated slave select pins for SPI. Any GPIO works so removed warning for no SS. Changed warning to SCK as the variants use 'SCK' nomencalture instead of 'CLK'.
|
Should have noted - this PR is an effort to fix warnings found in issue #55. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added return value to _interruptStatus. I'm not entirely confident we are returning all we should.
Here is example returning fault mask register as well.
Here is one of very few example sketches I could find that actually use the __interruptsStatus() call.
Also in this PR - Small changes to SPI.h. I decided to remove warnings to SS pin definition. I've never used a pin called 'SS' and use a GPIO for CS instead. Apollo3 doesn't have hardware support for SS so I think we can expunge it. Also, changed warning on 'CLK' to 'SCK'. I see SCK more often for SPI pins and this follows the pad map for Apollo3.